Draft: CSPL-4344 #1679
Draft: CSPL-4344 #1679
Conversation
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA igor.grzankowski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
Igor-splunk
force-pushed
the
CSPL-4344
branch
from
5c684e8 to
bf5a91d
Compare
| if licenseInfo.Status == "EXPIRED" { | ||
| eventPublisher.Warning(ctx, "LicenseExpired", | ||
| fmt.Sprintf("License '%s' has expired", licenseName)) | ||
| scopedLog.Info("Detected expired license", "licenseName", licenseName, "title", licenseInfo.Title) |
Pull Request Test Coverage Report for Build 21512929957Details
💛 - Coveralls |
| var pod corev1.Pod | ||
| err := client.Get(ctx, namespacedName, &pod) | ||
| if err != nil { | ||
| // Pod might not exist yet, which is normal during initial creation |
There was a problem hiding this comment.
Shouldn't we log something on return?
There was a problem hiding this comment.
Those tests look like they could be a table tests.
Which API call will fail in case of expected alerts? Shouldn't we mock it? I would prefer to have some positive test case
4 participants
Description
What does this PR have in it?
Key Changes
Highlight the updates in specific files
Testing and Verification
How did you test these changes? What automated tests are added?
Related Issues
Jira tickets, GitHub issues, Support tickets...
PR Checklist